lfs_dir_open() does not handle "." and ".." at end of a path

[husigeza]

Hello,

I noticed that lfs_dir_open() does not handle paths where the last "location" is given as "." or "..".
E.g.: "/test/mydirectory/.." or "/test/mydirectory/." will open directory "/" (root), but "/test/mydirectory/../mydirectory" opens "mydirectory" correctly.

Could you check this please ?

Thanks,
Geza

[geky]

Good find! Thanks for raising an issue.

I'm not sure I can change that behaviour easily, currently littlefs finds the last name and relies on the null terminator at the end of the path.

I might be able to use a length with the path name, but it'll need several changes to implement.

[geky]

Nevermind, it was still fixable in the current implementation. Although there was a bit of restructuring to make the check work out.

Does this fix work for you?
https://github.com/geky/littlefs/compare/fix-trailing-dots

[husigeza]

Hello,

Yes it works, thanks!