Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and update dependencies on first run or each command #33

Closed
sg- opened this issue Apr 7, 2016 · 8 comments
Closed

Install and update dependencies on first run or each command #33

sg- opened this issue Apr 7, 2016 · 8 comments
Assignees

Comments

@sg-
Copy link
Contributor

sg- commented Apr 7, 2016

In a clean environment there are many dependencies needed for tools. If neo is the entry to tools it should ensure all deps are installed as per the requirements for the version of tools. Initially this is just something like pip install -U -r requirements.txt but forward looking should install in a venv at the program level or system level depending on how tools are distributed.

@sg- sg- added the bug label Apr 7, 2016
@screamerbg
Copy link
Contributor

Great idea. Do you think Chris H can help with this?

@bogdanm
Copy link
Contributor

bogdanm commented Apr 7, 2016

pip install -U -r requirements.txt

Node that this might not be a good idea at all. The libraries managed by pip are common to all the programs managed by Python (and to the Python installation itself, which sometimes has an intimate connection with pip). Which means there's a chance that executing the above command might kill even the local Python installation (that happened to me a couple of times while trying to update yotta, using a similar mechanism). I'd defer this for now until we are able to offer venvs, or at least don't execute this command automatically, but rather let the user do it manually.

@geky
Copy link
Contributor

geky commented Apr 7, 2016

I'm seconding @bogdanm, modifying the user's global environment on innocuous commands sounds like a bad idea, especially for giving a good first impression.

Also I think we may want to keep workspace_tool stuff and scm stuff separate as much as possible, although this is debatable.

@sg-
Copy link
Contributor Author

sg- commented Apr 7, 2016

There is no question this should be in a venv. neo should create it, enter and install deps.

@screamerbg
Copy link
Contributor

neo should call environment setup script in tools which does the job. Any volunteer to write it?

@geky
Copy link
Contributor

geky commented Apr 12, 2016

I can look into it. Will keep this thread updated.

@geky geky self-assigned this Apr 12, 2016
@screamerbg
Copy link
Contributor

Now address in PR #119

@screamerbg
Copy link
Contributor

PR now accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants