Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper recovery if creating a key in a secure element fails #217

Closed
gilles-peskine-arm opened this issue Aug 13, 2019 · 2 comments
Closed

Comments

@gilles-peskine-arm
Copy link
Collaborator

Description

When creating a key in a secure element, if the call to the secure element's create method succeeds, but an error happens later (e.g. saving the driver's persistent data to storage), the API function reports a failure, but the key remains in the secure element. This is a resource leak and can be a data leak (when importing a key).

There may be other key creation errors that are not handled properly. This should be reviewed and tested.

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug
@ciarmcom
Copy link
Member

Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-863

@gilles-peskine-arm
Copy link
Collaborator Author

This issue only concerns dynamically registered secure element drivers enabled with MBEDTLS_PSA_CRYPTO_SE_C, which are deprecated. We do not intend to do any further work on that feature, even bug fixes, unless we have reports of it being used in the wild.

@gilles-peskine-arm gilles-peskine-arm closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants