Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVstore: use _storage_config_xxxx() in kv_config.cpp can just create one securestore instance,which is not accordant with "#define MAX_ATTACHED_KVS 3" in KVMap.h #12881

Closed
bianyu91 opened this issue Apr 29, 2020 · 3 comments

Comments

@bianyu91
Copy link

Description of defect

In mbed-os/features/storage/kvstore/KVMap.h has the following macro
#define MAX_ATTACHED_KVS 3
I think this macro defines the max number of kvstore_main_instances attached to KVMap.
But in kv_config.cpp

static kvstore_config_t kvstore_config;

and all the _ storage_config_XXXXAPIs,such as
int _storage_config_filesystem_common()
{

                   ret =kv_map.attach(STR(MBED_CONF_STORAGE_DEFAULT_KV),& kvstore_config);
                  }

just can define only one kvstore_main_instance with the default partition name"/kv/",what if need to define two or more kvstore_main_instances whose partition name should be different?

Target(s) affected by this defect ?

N/A

Toolchain(s) (name and version) displaying this defect ?

N/A

What version of Mbed-os are you using (tag or sha) ?

mbed-os-5.11.5

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

mbed-cli

How is this defect reproduced ?

Just view the source code

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2020

cc @ARMmbed/mbed-os-storage

@ciarmcom
Copy link
Member

ciarmcom commented Oct 2, 2020

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2157

@ciarmcom
Copy link
Member

We closed this issue because it has been inactive for quite some time and we believe it to be low priority. If you think that the priority should be higher, then please reopen with your justification for increasing the priority.

Issue Workflow automation moved this from Open to Done Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants