Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it acceptable to create a PR for mbed-os-5.15.x versions #13616

Closed
mbedNoobNinja opened this issue Sep 15, 2020 · 4 comments
Closed

Is it acceptable to create a PR for mbed-os-5.15.x versions #13616

mbedNoobNinja opened this issue Sep 15, 2020 · 4 comments

Comments

@mbedNoobNinja
Copy link
Contributor

mbedNoobNinja commented Sep 15, 2020

Description of defect

I thought that #13125 is the last version but suddenly an #13381 appeared!

If PR are still accepted, how should I structure them if I want to add support for:

  • components: ["SD", "FLASHIAP"]

  • device_has: ["USBDEVICE", "FLASH", "LPTICKER"]

  • bootloader_supported [:true]

SD will be with external lib, (probably with the name SDHI), because it does not use SPI bus, but the native SDHI controller, similar to some of the Nuvoton boards!

Target(s) affected by this defect ?

VK_RZ_A1H

Toolchain(s) (name and version) displaying this defect ?

ARM, GCC_ARM, IAR

What version of Mbed-os are you using (tag or sha) ?

#13125

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

Tool Version
mbed-cli 1.10.4

How is this defect reproduced ?

None

@ciarmcom
Copy link
Member

@mbedNoobNinja thank you for raising this issue.Please take a look at the following comments:

We cannot automatically identify a release based on the version of Mbed OS that you have provided.
Please provide either a single valid sha of the form #abcde12 or #3b8265d70af32261311a06e423ca33434d8d80de
or a single valid release tag of the form mbed-os-x.y.z .
E.g. 'mbed-os-5.15.x' has not been matched as a valid tag or sha.It would help if you could also specify the versions of any tools you are using?
How can we reproduce your issue?

NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.
Please update the issue header with the missing information, the issue will not be mirroredto our internal defect tracking system or investigated until this has been fully resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

I thought that #13125 is the last version but suddenly an #13381 appeared!

Yes, currently 5.15 is still opened.

What do you want to add ? Is it a target update ? The 5.15 branch is only for patch updates.

@mbedNoobNinja
Copy link
Contributor Author

mbedNoobNinja commented Sep 15, 2020

Target update

  • For now SD

  • In the near future the other mentioned above.

The question is how should I proceed 1 PR per component feature or device_has

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

Yes, ti should not be a problem. I'll close this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants