Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to skip unsupported tests with CTest #14856

Closed
Tracked by #14853
LDong-Arm opened this issue Jul 1, 2021 · 0 comments · Fixed by #14902
Closed
Tracked by #14853

Investigate how to skip unsupported tests with CTest #14856

LDong-Arm opened this issue Jul 1, 2021 · 0 comments · Fixed by #14902

Comments

@LDong-Arm
Copy link
Contributor

Description of defect

With Mbed CLI 1, unsupported tests are excluded in two ways:

  • Tests under excluded directories (e.g. FEATURE_BLE for a non-BLE target) are not compiled or listed at all
  • Tests under "visible" directories are listed, but during compile time the test source performs macros checks and raises #error [NOT_SUPPORT], which Mbed CLI 1 parses

Parsing an error message is not ideal, so we may use CMake to check feature availability instead. This task is to investigate how to do this.

Target(s) affected by this defect ?

N/A

Toolchain(s) (name and version) displaying this defect ?

N/A

What version of Mbed-os are you using (tag or sha) ?

mbed-os-6.12.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

N/A

How is this defect reproduced ?

N/A

@LDong-Arm LDong-Arm added this to Inbox in Mbed Core via automation Jul 1, 2021
@LDong-Arm LDong-Arm moved this from Inbox to To do (16) in Mbed Core Jul 1, 2021
@mbedmain mbedmain added this to Needs Triage in Issue Workflow Jul 1, 2021
@mbedmain mbedmain added this to Untriaged in Issue Severity Jul 1, 2021
@LDong-Arm LDong-Arm moved this from To do (16) to In progress (8) in Mbed Core Jul 7, 2021
@LDong-Arm LDong-Arm moved this from In progress (8) to Awaiting review (3) in Mbed Core Jul 9, 2021
@rwalton-arm rwalton-arm moved this from Awaiting review (3) to Review in progress (4) in Mbed Core Jul 14, 2021
@Patater Patater assigned Patater and LDong-Arm and unassigned Patater Jul 15, 2021
@Patater Patater moved this from Review in progress (4) to Reviewer approved & awaiting CI & merge (3) in Mbed Core Aug 11, 2021
Mbed Core automation moved this from Reviewer approved & awaiting CI & merge (3) to Done Aug 11, 2021
Issue Workflow automation moved this from Needs Triage to Done Aug 11, 2021
@Patater Patater moved this from Done to Reported in Mbed Core Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mbed Core
  
Reported
Development

Successfully merging a pull request may close this issue.

3 participants