-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NCS36510 - A4 and A5 pins are missing in PinNames #3508
Comments
@0xc0170 |
Thanks, a curiosity - why those pins are NC? We use those pins for https://github.com/ARMmbed/ci-test-shield tests. Here's AnalogOut test cases - https://github.com/ARMmbed/ci-test-shield/blob/master/TESTS/API/AnalogIn/AnalogIn.cpp#L67 |
If the pins are left out then the CI Test shied assertion should fail. We probably should add an assertion that tests to make sure none of the pins that are required are NC's. |
@0xc0170 Since the device does not have the ability to support A4 and A5, should they be set to NC in PinNames.h? Please provide your recommendation. Would this allow for a more graceful handling of test results when pins are not connected?
Note, I moved the definition of NC up before it is referenced. Currently NC is defined last in the long list, which makes it difficult to use. |
I can see this has been added in the latest PR merge. Can you close this now? |
Description
Bug
Target
NCS36510
Actual behavior
From
PinNames.h
file:Why A4 and A5 are not defined?
cc @radhika-raghavendran @pradeep-gr
The text was updated successfully, but these errors were encountered: