Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant include #2640

Closed
irwir opened this issue May 13, 2019 · 1 comment
Closed

Redundant include #2640

irwir opened this issue May 13, 2019 · 1 comment
Labels
bug component-platform Portability layer and build scripts

Comments

@irwir
Copy link
Contributor

irwir commented May 13, 2019

https://github.com/ARMmbed/mbedtls/blob/75d9a333cef532d55c01773add6dee1106da95c3/library/timing.c#L54

winbase.h should be already read in while including windows.h file.
@RonEld RonEld added bug component-platform Portability layer and build scripts tracking labels May 15, 2019
@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2849

Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
timing: Remove redundant include file
548ba2e 
There is no need to include winbase.h, as it will be pulled in by
windows.h as needed.

Fixes Mbed-TLS#2640
Patater added a commit to Patater/mbedtls that referenced this issue Jun 20, 2019
@Patater
timing: Remove redundant include file
b196a0a 
There is no need to include winbase.h, as it will be pulled in by
windows.h as needed.

Fixes Mbed-TLS#2640
@irwir irwir mentioned this issue Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-platform Portability layer and build scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ciarmcom @irwir @RonEld