Separate library, runtime, and archive destinations in cmake install target

[tkelman]

For example from libssh2's src/CMakeLists.txt, which is pretty typical:

install(TARGETS libssh2
  EXPORT Libssh2Config
  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
  ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})

This may need to include(GNUInstallDirs) to work with non-make generators. Right now with just the single mbedtls-specific LIB_INSTALL_DIR variable, both static libraries and shared libraries (and import libraries on Windows) are getting installed to the same location which is not the expected behavior on Windows. Typically Windows builds should put dll's in /bin (RUNTIME DESTINATION), static and import libraries in /lib. See https://cmake.org/cmake/help/v3.6/command/install.html#installing-targets.

I'll submit a patch if this sounds acceptable.

[ciarmcom]

ARM Internal Ref: IOTSSL-995

[tkelman]

Any comments on this?

[tkelman]

Bump. I'll gladly write a patch to fix this if I get any indication that someone would review it.

[yselkowitz]

--- a/library/CMakeLists.txt
+++ b/library/CMakeLists.txt
@@ -152,7 +152,9 @@ if(USE_SHARED_MBEDTLS_LIBRARY)
     target_link_libraries(mbedtls ${libs} mbedx509)

     install(TARGETS mbedtls mbedx509 mbedcrypto
-            DESTINATION ${LIB_INSTALL_DIR}
+            LIBRARY DESTINATION ${LIB_INSTALL_DIR}
+            ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
+            RUNTIME DESTINATION bin
             PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE)
 endif(USE_SHARED_MBEDTLS_LIBRARY)