Allow configuring MBEDTLS_TLS_EXT_CID at compile time #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
mbed TLS team
needs-review
gilles-peskine-arm
added this to To Do
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
via automation
gilles-peskine-arm
force-pushed
the
tls_ext_cid-config
branch
from
95d3812
to
e77d758
Compare
|
First, thanks for addressing my issue with this PR.
FMPOV, it's more important for 2.2x. The draft-ietf-tls-dtls-connection-id is currently reviewed and the requested changes so far are about terms on expressions, but not longer the used data and security functions. So, hope it gets released within the next months and then with a stable defined MAC and code points. |
mpg
added
the
needs-backports
bensze01
moved this from To Do
to Has Approval
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
automation
moved this from Has Approval
to In Progress
Apr 27, 2021
mpg
previously approved these changes
Apr 27, 2021
bensze01
moved this from In Progress
to Has Approval
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
|
Two reviewers thus removing the "needs: reviewer" label. @hanno-arm please shout if you don't have time to review it. |
ronald-cron-arm
removed
the
needs-reviewer
hanno-becker
previously approved these changes
Jun 4, 2021
mpg
added
needs-work
and removed
needs-review
|
Needs rebasing to resolve conflicts. |
The numerical identifier of the CID extension hasn't been settled yet and different implementations use values from different drafts. Allow configuring the value at compile time. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
mpg
force-pushed
the
tls_ext_cid-config
branch
from
e77d758
to
7dd2f50
Compare
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
automation
moved this from Has Approval
to In Development
Aug 12, 2021
mpg
added
needs-review
mpg
moved this from In Development
to In Review
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
yanesca
approved these changes
Aug 12, 2021
yanesca
moved this from In Review
to Has Approval
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
mpg
approved these changes
Aug 13, 2021
mpg
added
approved
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
automation
moved this from Has Approval
to Done
Aug 13, 2021
daverodgman
removed this from Done
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numerical identifier of the CID extension hasn't been settled yet and different implementations use values from different drafts. Allow configuring the value at compile time as discussed in #3892 (comment).
This PR is for 3.0. 2.x PR