Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing config check for PKCS5. #5438

Merged
merged 1 commit into from Jan 21, 2022

Conversation

SebastianBoe
Copy link
Contributor

@SebastianBoe SebastianBoe commented Jan 19, 2022

PKCS5 depends on MD, but is missing a config check resulting in
obscure errors on invalid configurations.

Signed-off-by: Sebastian Bøe sebastian.boe@nordicsemi.no

Backport: #5439

PKCS5 depends on MD, but is missing a config check resulting in
obscure errors on invalid configurations.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d) needs-backports Backports are missing or are pending review and approval. labels Jan 19, 2022
@gilles-peskine-arm
Copy link
Contributor

Thanks! Can you please make a similar patch to mbedtls-2.28, since it has the same issue?

@SebastianBoe
Copy link
Contributor Author

Done.
#5439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants