Adding develpment var flag #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evilbot test channel
|
@jtmichelson It's worth noting that I thought about adding these checks to the main so there would be less code. Sometimes events don't come from a channel so I decided I would let the event handlers handle it for their specific circumstances. Maybe we should make some event_handler_trait that each event handler will implement? |
jtmichelson
approved these changes
Dec 20, 2022
| @@ -23,6 +23,12 @@ pub async fn handle_message_event(body: &Value) { | |||
| .as_str() | |||
| .unwrap_or("invalid_enterprise_user_id"); | |||
| let _user: &str = body["event"]["user"].as_str().unwrap_or("invalid_user"); | |||
| let is_development = get_env_var("IS_DEVELOPMENT"); | |||
| // Stop the function if this is a development environment and outside the test channel | |||
| if channel != "C0351GJ62Q0" && is_development == "true" { | |||
There was a problem hiding this comment.
Parse the is_development flag and use it as a regular boolean. Don't use string comparison here.
Something like:
let is_development: bool = get_env_var("IS_DEVELOPMENT").parse().unwrap();
Also you might want to do this once in main and pass it into the handlers.
…ded test channel id as an env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When devilbot is handling an event, it checks accordingly to the event to see if it should respond. If it is a development stage and the event came from outside the test channel then the function returns. Resolves #54