refactor: 给部分代码添加注释 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
michaelfyc
force-pushed
the
michaelfyc-add-ut-20210830
branch
2 times, most recently
from
d9cc2c0
to
d99afbe
Compare
yllhwa
reviewed
Aug 31, 2021
| } | ||
| private final static Logger log = LoggerFactory.getLogger(ICheckServiceImpl.class); | ||
| /** | ||
| * unicode 编码中，中文字符占两个字节，因此文本最大长度设为2000而非1000 |
There was a problem hiding this comment.
不知道，我没改这里的代码🤔如果没有乘2的话那么related的长度是不是也不用除以2了？
There was a problem hiding this comment.
2000是因为我设置的就是2000，想要和前端统一的话改成1000就好了（）
michaelfyc
force-pushed
the
michaelfyc-add-ut-20210830
branch
2 times, most recently
from
2c5d87b
to
e988dcb
Compare
michaelfyc
force-pushed
the
michaelfyc-add-ut-20210830
branch
from
e988dcb
to
659266d
Compare
yllhwa
approved these changes
Sep 5, 2021
| } | ||
| return stringSegs; | ||
| } | ||
| static List<String> getStringSegs(String s) { |
There was a problem hiding this comment.
此函数使用滑动窗口将字符串分段以便比较，用到的地方就是两个文本段相同部分的标记(compareArticle函数)。可以换成新的算法来标记(前端用上了)。
There was a problem hiding this comment.
注释加上了。
可以换成新的算法来标记(前端用上了)。
这个怎么说？
michaelfyc
force-pushed
the
michaelfyc-add-ut-20210830
branch
from
659266d
to
54f9f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
根据 #35 的editorconfig文件更改了大部分代码缩进
给 ArticleCompareUtil 添加注释，把 main 的测试移到 test 目录下做单元测试
把工具类的 main 测试移动到 test 目录下
给 ICheckService 和 ICheckServiceImpl 添加注释,并调整了部分写法
将部分类或者函数的注释改成javadoc格式的注释
给 LeaderBoard 添加了注释并调整了部分写法