-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
414 Request-URI Too Large: Switch to POST if the URI is too long #2
Comments
|
Thanks for this issue, it is a good idea to use this config parameter. I will try to implement it, but it could take some time. PRs are generally welcome |
@rumbin Can you provide some test data to reproduce the issue? |
Any complicated or large export from excalidraw.com should work. Facing this as well, would be great if it could be switched to |
I just looked into this issue, but as far as I can see, there is other basic problem with that. If so, I only see the option to first download the drawing (which is optional at the moment).
Feedback please! |
Not sure I fully understand the image tag reference and I have limited Python knowledge, but looking at the plugin code, it seems that it is using Maybe there is another way to implement this using the standard library by passing in |
@b-bittner Yes, you are right. Your solution would work as a quick fix. I looked into the asciidoc plugin and it seems, that they are doing the request via JS in the browser at a later stage. This may also be an option. |
This issue should now be fixed with #7 |
Problem Description
When an (excalidraw) drawing is too large (contains too many characters), then the URI becomes too large.
This results in the image not being renderd in MkDocs. Instead, a placeholder image is shown:
I suppose that this is caused by the drawing code being too long.
At least that is what https://kroki.io/#try shows when providing a too long excalidraw JSON.
Possible solution:
Switch to
POST
, either always or only if the URI would become too long.For reference, see identical issues of other languages and their solutions:
kroki-http-method
The text was updated successfully, but these errors were encountered: