Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest with dockerized Basilisk #81

Open
Mark2000 opened this issue Nov 1, 2023 · 0 comments
Open

Run pytest with dockerized Basilisk #81

Mark2000 opened this issue Nov 1, 2023 · 0 comments
Labels
enhancement New feature or request infrastructure

Comments

@Mark2000
Copy link
Contributor

Mark2000 commented Nov 1, 2023

Pytest suite should be run automatically as a GitHub action. Requires containerized Basilisk environment to run; @patkenneally has done this for LASP, may be a good starting point.

Challenges:

  • How to handle Basilisk/bsk_rl version compatibility? Develop of rl may be dependent on latest develop of basilisk
  • Where to run?

For example scripts, would be really nice to give output in documentation for time to run at each release (I think a fairly standard feature) as a way of keeping an eye on any big performance issues.

@Mark2000 Mark2000 added enhancement New feature or request infrastructure labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant