Fix undo redo bugs #243
Merged
Fix undo redo bugs #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix-undo-redo
… into fix-undo-redo
KxxMxxx
reviewed
Nov 9, 2019
Comment on lines
+49
to
+53
| if (!isUndoRedo) { | ||
| Event clearEvent = EventFactory.parse((UndoableCommand) this, model); | ||
| CommandHistory.addToUndoStack(clearEvent); | ||
| CommandHistory.clearRedoStack(); | ||
| } |
There was a problem hiding this comment.
Since command is an abstract class, this block of code can be abstracted out to another method, and when the even is undoable, it calls said method within the execute method. This would reduce the number of duplicate codes since all undoable command has this block of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259
Closes #180
Closes #178
Closes #159