Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JsonAdaptedPerson #109

Open
iskandarzulkarnaien opened this issue Oct 14, 2019 · 2 comments
Open

Refactor JsonAdaptedPerson #109

iskandarzulkarnaien opened this issue Oct 14, 2019 · 2 comments
Assignees
@C-likethis123
Labels
Discussion priority.Medium Nice to have type.Refactor
Projects
Other enhancement/refactor

Comments

@iskandarzulkarnaien
Copy link

JsonAdaptedPerson class is currently bloated with attributes from all types of persons. As a result, it represents, for example, a doctor by setting all its non-doctor related attributes such as age, bloodType, etc to empty strings.

Proposed refactoring is to have JsonAdaptedPerson be an abstract class with JsonAdaptedDoctor/Patient/etc extending it. Naturally, this issue should be fixed after #102 .

Issue up for discussion.
@iskandarzulkarnaien iskandarzulkarnaien mentioned this issue Oct 15, 2019
Closed
@iskandarzulkarnaien
Copy link
Author

Related to and should be PR in together with #111

@nus-se-bot nus-se-bot mentioned this issue Oct 16, 2019
Open
26 tasks
@C-likethis123
Copy link

Hi guys, I will take on this issue.

@C-likethis123 C-likethis123 self-assigned this Oct 31, 2019
@C-likethis123 C-likethis123 mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@C-likethis123 C-likethis123

Labels
Discussion priority.Medium Nice to have type.Refactor
Projects
Other enhancement/refactor
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@C-likethis123 @iskandarzulkarnaien