Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Note test cases. #336

Merged
merged 6 commits into from Nov 8, 2019
Merged

Conversation

Sam-limyr
Copy link

@Sam-limyr Sam-limyr commented Nov 7, 2019

Added:

  • ViewNoteCommandTest
  • Ability for punctuation to be used in Note Titles

Improved:

  • DeleteNoteCommandTest
  • ViewRawNoteCommandTest

Edited:

  • delete commands to check if CommandHistory is empty
  • NoteFragment prefix constants by moving them to NoteFeatureUtil

@Sam-limyr Sam-limyr added this to the v1.4 milestone Nov 7, 2019
@Sam-limyr Sam-limyr self-assigned this Nov 7, 2019
@Sahilgat
Copy link

Sahilgat commented Nov 8, 2019

Looks good, I'll take a look at your DeleteNoteCommandTest and may adapt it! :)

@Sahilgat Sahilgat merged commit 704dc2c into AY1920S1-CS2103T-W13-3:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants