Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Attributes do not have max length #105

Closed
AaronCQL opened this issue Mar 28, 2020 · 0 comments · Fixed by #109
Closed

[BUG] Attributes do not have max length #105

AaronCQL opened this issue Mar 28, 2020 · 0 comments · Fixed by #109
Assignees
@AaronCQL @ziyingli
Labels
severity.Low A bug that is unlikely to affect normal operations, appears very rarely type.Bug A BUG type.Enhancement An enhancement to an existing story
Milestone
v1.3

Comments

@AaronCQL
Copy link

Attributes CurrentWeight, TargetWeight, Height, do not have max length. Setting a long height of 174.2222222222222 is currently possible and may affect GUI display.

Possible implementations:

  1. Disallow any number with more than 3 numbers before or after the decimal place (easier)
  2. Allow but truncate before saving the data (harder)

Remark, Sports, Tag may need to have a maximum length too.
@AaronCQL AaronCQL added type.Enhancement An enhancement to an existing story type.Bug A BUG severity.Low A bug that is unlikely to affect normal operations, appears very rarely labels Mar 28, 2020
@AaronCQL AaronCQL added this to the v1.3 milestone Mar 28, 2020
@AaronCQL AaronCQL mentioned this issue Mar 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronCQL AaronCQL

@ziyingli ziyingli

Labels
severity.Low A bug that is unlikely to affect normal operations, appears very rarely type.Bug A BUG type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Fix max length of attributes AY1920S2-CS2103T-F11-2/main
2 participants
@AaronCQL @ziyingli