Add checks for assign, unassign and reassign commands #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnsyn
reviewed
Oct 28, 2020
| * This defines a stronger notion of equality between two role requirements. | ||
| */ | ||
| @Override | ||
| public boolean equals(Object other) { | ||
| return other == this | ||
| || (other instanceof RoleRequirement | ||
| && role.equals(((RoleRequirement) other).role) | ||
| && quantity == ((RoleRequirement) other).quantity); | ||
| && quantityRequired == ((RoleRequirement) other).quantityRequired | ||
| && quantityRequired == ((RoleRequirement) other).quantityRequired); |
| * Returns true if the quantity filled has not reached the quantity required. | ||
| */ | ||
| public boolean isFilled() { | ||
| assert quantityFilled <= quantityRequired; |
There was a problem hiding this comment.
Would it be more meaningful to put this assertion in the constructor instead? Just a suggestion, not sure if it's good practice
tnsyn
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55