Add view command #111

tohyuting · 2020-10-11T09:16:29Z

View Command has been implemented, and list command as been edited.
Also amended the first entry of json file/typical warehouses since a match by first word of name in list test would result in finding for the word (warehouse), which would cause all 7 entries to be found by the predicate function.

Edited User Guide to include list command, have also updated the developer guide for list command's use case.

codecov-io · 2020-10-11T09:17:50Z

Codecov Report

Merging #111 into master will increase coverage by 0.53%.
The diff coverage is 94.87%.

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     69.45%   69.99%   +0.53%     
- Complexity      538      551      +13     
============================================
  Files            87       89       +2     
  Lines          1814     1853      +39     
  Branches        211      217       +6     
============================================
+ Hits           1260     1297      +37     
- Misses          507      508       +1     
- Partials         47       48       +1

Impacted Files	Coverage Δ	Complexity Δ
...n/java/seedu/clinic/logic/parser/ClinicParser.java	`73.68% <0.00%> (-4.10%)`	`10.00 <0.00> (ø)`
.../java/seedu/clinic/logic/commands/ViewCommand.java	`95.45% <95.45%> (ø)`	`8.00 <8.00> (?)`
.../java/seedu/clinic/logic/commands/ListCommand.java	`100.00% <100.00%> (ø)`	`2.00 <0.00> (ø)`
...a/seedu/clinic/logic/parser/ViewCommandParser.java	`100.00% <100.00%> (ø)`	`5.00 <5.00> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c11250...941fb95. Read the comment docs.

qlchan24

Apart from minor comments, LGTM

qlchan24 · 2020-10-11T12:42:36Z

src/main/java/seedu/clinic/logic/commands/ViewCommand.java

+import seedu.clinic.model.attribute.NameContainsKeywordsPredicateForSupplier;
+import seedu.clinic.model.attribute.NameContainsKeywordsPredicateForWarehouse;
+
+public class ViewCommand extends Command {


To do javadocs

Thanks for pointing this out, missed out on the javadocs comment for class!

qlchan24 · 2020-10-11T12:50:35Z

src/test/data/JsonSerializableClinicTest/typicalWarehousesClinic.json

@@ -2,7 +2,7 @@
  "_comment": "Clinic save file which contains the same supplier values as in TypicalSuppliers#getTypicalAddressBook()",


comment should be updated as well

Noted, will updated in next commit as well.

qlchan24 · 2020-10-11T12:52:25Z

src/test/java/seedu/clinic/logic/commands/ListCommandTest.java

@@ -32,8 +34,14 @@ public void execute_listIsNotFiltered_showsSameList() {
    }

    @Test
-    public void execute_listIsFiltered_showsEverything() {
+    public void execute_listIsFilteredSupplier_showsEverythingWarehouseShowOneSupplier() {


i think the naming for this is a bit confusing, at least at first glance, perhaps can change everything to all

qlchan24 · 2020-10-11T13:00:14Z

src/test/java/seedu/clinic/logic/parser/ViewCommandParserTest.java

+
+    @Test
+    public void parse_correctTypeCorrectKeyWords_success() {
+        ViewCommand expectedViewCommand1 = new ViewCommand("supplier", Arrays.asList(new String[]


I think you can just use list.of() instead of arrays.aslist(String[]{})

Thanks for the suggestion, let me try to use that instead of arrays.aslist(String[]{})

qlchan24 · 2020-10-11T13:03:59Z

src/test/java/seedu/clinic/testutil/TypicalSupplier.java

@@ -80,6 +81,9 @@ public static Clinic getTypicalClinic() {
        for (Supplier supplier : getTypicalSuppliers()) {
            ab.addSupplier(supplier);


ab used to stand for addressbook, now it has no meaning so i think it should be changed

jeffreytjs

Looks good

…ommand Add view command

tohyuting added 3 commits October 10, 2020 21:28

Add view command and updated list command

d6722a8

Merge branch 'master' of team repo into add-viewCommand

f2445a0

Add view command and test cases, update list command and test cases

c80cf9d

qlchan24 reviewed Oct 11, 2020

View reviewed changes

Fix naming, javadocs and remove traces of addressbook

413f011

tohyuting added this to the v1.2 milestone Oct 11, 2020

tohyuting added 2 commits October 11, 2020 23:34

Fix merge conflicts

8d777fa

Fix import statements ordering

941fb95

jeffreytjs approved these changes Oct 11, 2020

View reviewed changes

jeffreytjs merged commit 4162055 into AY2021S1-CS2103-W14-4:master Oct 11, 2020

tohyuting self-assigned this Oct 12, 2020

tohyuting added the hacktoberfest-accepted label Oct 24, 2020

jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020

Merge pull request AY2021S1-CS2103-W14-4#111 from tohyuting/add-viewC…

2d9daa8

…ommand Add view command

jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020

Merge pull request AY2021S1-CS2103-W14-4#111 from tohyuting/add-viewC…

ee70f91

…ommand Add view command

jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020

Merge pull request AY2021S1-CS2103-W14-4#111 from tohyuting/add-viewC…

bf9726d

…ommand Add view command

jeffreytjs added a commit to jeffreytjs/CLI-nic that referenced this pull request Oct 27, 2020

Merge pull request AY2021S1-CS2103-W14-4#111 from tohyuting/add-viewC…

a59bde4

…ommand Add view command

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add view command #111

Add view command #111

tohyuting commented Oct 11, 2020

codecov-io commented Oct 11, 2020 •

edited

qlchan24 left a comment

qlchan24 Oct 11, 2020

tohyuting Oct 11, 2020

qlchan24 Oct 11, 2020

tohyuting Oct 11, 2020

qlchan24 Oct 11, 2020

qlchan24 Oct 11, 2020

tohyuting Oct 11, 2020

qlchan24 Oct 11, 2020

jeffreytjs left a comment

		@@ -2,7 +2,7 @@
		"_comment": "Clinic save file which contains the same supplier values as in TypicalSuppliers#getTypicalAddressBook()",

		@@ -80,6 +81,9 @@ public static Clinic getTypicalClinic() {
		for (Supplier supplier : getTypicalSuppliers()) {
		ab.addSupplier(supplier);

Add view command #111

Add view command #111

Conversation

tohyuting commented Oct 11, 2020

codecov-io commented Oct 11, 2020 • edited

Codecov Report

qlchan24 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeffreytjs left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 11, 2020 •

edited