Add command add product supplier #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
============================================
+ Coverage 69.99% 70.39% +0.40%
- Complexity 551 563 +12
============================================
Files 89 91 +2
Lines 1853 1895 +42
Branches 217 222 +5
============================================
+ Hits 1297 1334 +37
- Misses 508 509 +1
- Partials 48 52 +4
Continue to review full report at Codecov.
|
zhengweii
reviewed
Oct 12, 2020
| private final Product productToAdd; | ||
|
|
||
| /** | ||
| * Creates an AddCommand to add the specified {@code Supplier} |
| @@ -9,8 +9,8 @@ | |||
| */ | |||
| public class Tag { | |||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = "Tags names should be alphanumeric"; | |||
| public static final String VALIDATION_REGEX = "\\p{Alnum}+"; | |||
| public static final String MESSAGE_CONSTRAINTS = "Tags names should be a word character"; | |||
There was a problem hiding this comment.
I think this message could be clearer! Perhaps something along the lines of "Tag names should contain only 1 word"!
| import seedu.clinic.model.supplier.Supplier; | ||
|
|
||
| /** | ||
| * Adds a product to a supplier to the CLI-nic app. |
There was a problem hiding this comment.
Perhaps this could be "Adds a product to a supplier in the CLI-nic app"!
| } | ||
|
|
||
| public static Supplier getSupplierByName(Name supplierName, Model model) throws NoSuchElementException { | ||
| return model.getClinic().getSupplierList().stream() |
There was a problem hiding this comment.
Just wondering if this violates the law of Demeter?
jeffreytjs
pushed a commit
to jeffreytjs/CLI-nic
that referenced
this pull request
Oct 27, 2020
…nd-add-product-supplier Add command add product supplier
jeffreytjs
pushed a commit
to jeffreytjs/CLI-nic
that referenced
this pull request
Oct 27, 2020
…nd-add-product-supplier Add command add product supplier
jeffreytjs
pushed a commit
to jeffreytjs/CLI-nic
that referenced
this pull request
Oct 27, 2020
…nd-add-product-supplier Add command add product supplier
jeffreytjs
pushed a commit
to jeffreytjs/CLI-nic
that referenced
this pull request
Oct 27, 2020
…nd-add-product-supplier Add command add product supplier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.