Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D] Mark visited command seems unnecessary #243

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 1 comment
Closed

[PE-D] Mark visited command seems unnecessary #243

nus-pe-bot opened this issue Oct 30, 2020 · 1 comment
Assignees

Comments

@nus-pe-bot
Copy link

The markVisited-attraction command seems to achieve the same result as executing "edit-attraction INDEX v/TRUE".

While this markVisited-attraction command may be more intuitive, it may also come across as a duplicate feature / unnecessary command since its purpose is already fulfilled by another command.

Furthermore, if a user wants to mark an attraction as not visited, there is no markUnvisited command or something similar, so the user will likely execute "edit-attraction INDEX v/FALSE", and in that case, since they are using the edit-attraction command to achieve this, it may seem odd that they use the markVisited-attraction command specifically to mark an attraction as visited but have to use a different command (edit-attraction) to mark is as not visited. At this point, they may be better off just achieving both results using the edit-attraction command.


Labels: severity.Low type.FeatureFlaw
original: shawn-nyk/ped#4

@peter-yeh
Copy link

10 reasons why we need markVisited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants