Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify find command implementation #55

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

pr4aveen
Copy link
Collaborator

Closes #54

@pr4aveen pr4aveen added the priority.Medium Nice to have label Oct 14, 2020
@pr4aveen pr4aveen self-assigned this Oct 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #55 into master will decrease coverage by 0.26%.
The diff coverage is 79.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     72.50%   72.23%   -0.27%     
+ Complexity      590      589       -1     
============================================
  Files            99      100       +1     
  Lines          1822     1826       +4     
  Branches        194      195       +1     
============================================
- Hits           1321     1319       -2     
- Misses          427      430       +3     
- Partials         74       77       +3     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/momentum/logic/commands/FindCommand.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...t/predicates/TagListContainsKeywordsPredicate.java 83.33% <71.42%> (-11.12%) 10.00 <2.00> (-1.00)
...edicates/DescriptionContainsKeywordsPredicate.java 75.00% <75.00%> (-15.91%) 8.00 <4.00> (-1.00)
...ject/predicates/NameContainsKeywordsPredicate.java 75.00% <75.00%> (-15.91%) 8.00 <4.00> (-1.00)
...seedu/momentum/logic/parser/FindCommandParser.java 70.00% <81.81%> (ø) 11.00 <3.00> (+1.00)
...du/momentum/model/project/predicates/FindType.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...um/logic/statistic/PeriodicTotalTimeStatistic.java 74.41% <0.00%> (-0.59%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deca8a8...70ad493. Read the comment docs.

Copy link
Collaborator

@kkangs0226 kkangs0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr4aveen pr4aveen added this to In progress in v1.2 (by 16/10/2020) via automation Oct 14, 2020
@pr4aveen pr4aveen added this to the v1.2 milestone Oct 14, 2020
@pr4aveen pr4aveen merged commit 8c51cde into AY2021S1-CS2103T-T10-1:master Oct 14, 2020
v1.2 (by 16/10/2020) automation moved this from In progress to Done Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make find command more extensible
4 participants