Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] 'sadd' and invalid dates (eg. 31st Feb) #177

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 0 comments · Fixed by #221
Closed

[PE-D] 'sadd' and invalid dates (eg. 31st Feb) #177

nus-pe-bot opened this issue Oct 30, 2020 · 0 comments · Fixed by #221
Assignees
@benclmnt
Milestone
v1.4

Comments

@nus-pe-bot
Copy link

Invalid dates do not seem to be handled:

Case1: 31/02/2020 2400
image.png
Case2: 31/02/2020 1200
image.png

Possibly throw an error message if the date entered is invalid?

Labels: severity.Medium type.FunctionalityBug
original: wengfaing/ped#3
@benclmnt benclmnt self-assigned this Oct 30, 2020
@benclmnt benclmnt mentioned this issue Oct 31, 2020
Merged
@benclmnt benclmnt added this to the v1.4 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benclmnt benclmnt

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Handle invalid dates in a strict manner.
2 participants
@benclmnt @nus-pe-bot