Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] update command - Updating to the same name should throw error instead #176

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 2 comments · Fixed by #226
Closed

[PE-D] update command - Updating to the same name should throw error instead #176

nus-pe-bot opened this issue Oct 30, 2020 · 2 comments · Fixed by #226
Assignees
@jiaax
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@nus-pe-bot
Copy link

For a profile named Chris, when I typed 'update n/Chris', the profile was updated successfully even though there was no change. Minor bug, but might be better to foolproof this.

image.png

Labels: severity.VeryLow type.FeatureFlaw
original: nicholas-gcc/ped#6
@wayne987
Copy link

but some people can have the same name tho, and we have the id to uniquely identify someone

@wayne987 wayne987 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 30, 2020
@jiaax
Copy link

jiaax commented Nov 1, 2020

will update to make sure it's unique ID instead!

@jiaax jiaax self-assigned this Nov 1, 2020
@jiaax jiaax linked a pull request Nov 4, 2020 that will close this issue
Person identified by ID only #226
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiaax jiaax

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Person identified by ID only jiaax/tp
3 participants
@jiaax @nus-pe-bot @wayne987