-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Review] Vavinan #43
Comments
Thank you. |
Ok understood, then this should be fine! |
Oh and I missed out something, Is the category always an integer as well,? because you did parseInt() which might cause an uncaught exception to be thrown |
Try not to say that the error is unknown, because in the PE all errors should be known and accounted for
In here, I don't think there is a need to check whether the data is a integer. This is because the Integer.parseInt method will automatically throw the number format exception if it fails
You should add some error handling here because the user might access out-of-bounds for the splitted string "parts"
Overall code looks organized but there are some parts where the function serve almost the same purpose as another. For example parseTransactionType and parseTransaction are the same except for the separator. Perhaps, more descriptive names can be used to differentiate the two or you could abstract the repeated logic out into another function.
The text was updated successfully, but these errors were encountered: