Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the database query of results-view and the data structures of r... #53

Merged
merged 2 commits into from Dec 11, 2012
Merged

Improved the database query of results-view and the data structures of r... #53

merged 2 commits into from Dec 11, 2012

Conversation

atsnisov
Copy link
Contributor

@atsnisov atsnisov commented Dec 5, 2012

...esults view.

@vkaravir
Copy link
Contributor

vkaravir commented Dec 5, 2012

In cases where an exercise has no submissions, this fails in results_for_template to exception unsupported operand type(s) for +: 'int' and 'NoneType'.

I also added some inline comments to the code.

@vkaravir
Copy link
Contributor

vkaravir commented Dec 5, 2012

And to add to the above, as a result of the exception the template shows a table without any students.

@ghost ghost assigned atsnisov Dec 8, 2012
vkaravir added a commit that referenced this pull request Dec 11, 2012
Improved the database query of results-view and the data structures of r...
@vkaravir vkaravir merged commit 5401b94 into apluslms:master Dec 11, 2012
skulonen added a commit to skulonen/a-plus that referenced this pull request May 3, 2021
This commit highlights the currently selected option in checkbox/radio
button exercises using a light blue rounded rectangle. The rectangle
appears underneath the currently focused option, and "pops out" slightly
at the time of selection, appearing as a subtle animation. This helps
users notice if they have accidentally selected an option while
scrolling through the exercise.

Fixes apluslms#53
skulonen added a commit to skulonen/mooc-grader that referenced this pull request May 5, 2021
Wrap the labels of checkboxes and radio buttons in `span` elements, so
they can be selected using css.

Related to apluslms/a-plus#53
skulonen added a commit to skulonen/a-plus that referenced this pull request May 5, 2021
skulonen added a commit to skulonen/a-plus that referenced this pull request May 5, 2021
This commit highlights the currently selected option in checkbox/radio
button exercises using a light blue rounded rectangle. The rectangle
appears underneath the currently focused option, and "pops out" slightly
at the time of selection, appearing as a subtle animation. This helps
users notice if they have accidentally selected an option while
scrolling through the exercise.

Fixes apluslms#53

Highlight all selected options, bold

Related to apluslms#53
skulonen added a commit to skulonen/a-plus that referenced this pull request May 5, 2021
This commit highlights the currently selected option in checkbox/radio
button exercises using a light blue rounded rectangle. The rectangle
appears underneath the currently focused option, and "pops out" slightly
at the time of selection, appearing as a subtle animation. This helps
users notice if they have accidentally selected an option while
scrolling through the exercise.

Fixes apluslms#53

Highlight all selected options, bold

Related to apluslms#53
@skulonen
Copy link
Contributor

skulonen commented May 5, 2021

Disregard the last 5 references. I accidentally linked to this pull request instead of the issue with the same id in mooc-grader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants