Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dates correctly #46

Closed
Aariq opened this issue Nov 1, 2020 · 1 comment
Closed

Handle dates correctly #46

Aariq opened this issue Nov 1, 2020 · 1 comment
Labels
enhancement New feature or request Priority: Low
Milestone
v1.0.0

Comments

@Aariq
Copy link
Owner

Aariq commented Nov 1, 2020

Previously Dates could be used as the time variable in bumbl(), but they were silently coerced to numeric by ifelse(). For now, I only allow numeric variables for time. I should change this to rlang::if_else() and handle Dates properly.
@Aariq Aariq added enhancement New feature or request Priority: Low labels Nov 1, 2020
@Aariq Aariq added this to the v1.0.0 milestone Feb 17, 2021
@Aariq
Copy link
Owner Author

Aariq commented Apr 14, 2021

I changed my mind on this. I think only allowing numeric variables for time is fine. The user can convert dates to numeric.

@Aariq Aariq closed this as completed Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Priority: Low
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@Aariq