You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be good to ensure that the signatures for Namespace#create_x methods are the same as the signatures for the corresponding X#initialize methods (besides the generator parameter), improving the internal consistency of Parlour.
For example, the signature for Namespace#create_method is:
(This would have to be considered a breaking change.)
This consistency could also to enforced in tests by having a test which grabs method parameters and compares for each, adding a layer of protection against adding a parameter to one but not the other by accident.
The text was updated successfully, but these errors were encountered:
It would be good to ensure that the signatures for
Namespace#create_x
methods are the same as the signatures for the correspondingX#initialize
methods (besides thegenerator
parameter), improving the internal consistency of Parlour.For example, the signature for
Namespace#create_method
is:But the signature for
Method#initialize
uses some positional arguments as keyword arguments instead:(This would have to be considered a breaking change.)
This consistency could also to enforced in tests by having a test which grabs method parameters and compares for each, adding a layer of protection against adding a parameter to one but not the other by accident.
The text was updated successfully, but these errors were encountered: