Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large bundle because of dependencies #45

Closed
Paso opened this issue May 13, 2019 · 2 comments · Fixed by #48
Closed

Large bundle because of dependencies #45

Paso opened this issue May 13, 2019 · 2 comments · Fixed by #48

Comments

@Paso
Copy link

Paso commented May 13, 2019

The minified bundle is 14kB while the raw source is only 4kB, this is probably because some dependencies are included in the bundle. It should be up to the user of the package to install the required dependencies so that they are not duplicated in the requiring application. To resolve this the package.json should switch to peerDependencies instead of dependencies.

@AaronCCWong
Copy link
Owner

Agreed. I'll accept a PR from you or I can make the update later this week or early next week.

@Paso
Copy link
Author

Paso commented Jun 25, 2019

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants