Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multi inputs, take 2 #175

Merged
merged 14 commits into from Apr 30, 2014
Merged

Allow multi inputs, take 2 #175

merged 14 commits into from Apr 30, 2014

Conversation

AaronLasseigne
Copy link
Owner

No description provided.

@AaronLasseigne
clean up tests
e8ed31e 
Conflicts:
	spec/active_interaction/base_spec.rb
@tfausak tfausak mentioned this pull request Apr 29, 2014
Closed
4 tasks
@tfausak tfausak added this to the v1.2.0 milestone Apr 29, 2014
@tfausak
Copy link
Collaborator

tfausak commented Apr 30, 2014

OpenStruct doesn't respond to [] and []= in Ruby < 2.0.0. We'll have to either refactor it to use send or define those methods on our GroupedInput class.

@tfausak
Copy link
Collaborator

tfausak commented Apr 30, 2014

At long last, the build is green. I think this is ready to merge.

@tfausak tfausak mentioned this pull request Apr 30, 2014
Closed
@AaronLasseigne AaronLasseigne merged commit 7de2f95 into v1.2.0 Apr 30, 2014
@AaronLasseigne AaronLasseigne deleted the multi-inputs-via-struct branch April 30, 2014 15:35
@tfausak tfausak mentioned this pull request Sep 3, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronLasseigne @tfausak