Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting the runtime fails. #13

Closed
ghost opened this issue May 24, 2020 · 5 comments · Fixed by #14
Closed

Starting the runtime fails. #13

ghost opened this issue May 24, 2020 · 5 comments · Fixed by #14

Comments

@ghost
Copy link

ghost commented May 24, 2020

Starting the runtime fails sometimes because of a issue in the get_current_dir_filepath function

int32_t remaining = (int32_t)(filename_dest - buffer);

Should probably be
int32_t remaining = (int32_t)DNNE_MAX_PATH - (filename_dest - buffer);

@AaronRobinsonMSFT
Copy link
Owner

@alberts2 The length of the buffer is passed in so I think it could be the following:

int32_t remaining = len - (filename_dest - buffer);

Thanks for reporting this. I will push up a new version ASAP.

@AaronRobinsonMSFT
Copy link
Owner

@alberts2 As a confirmation was this observed on a non-Windows platform? I am occasionally still getting the following on macOS, but have no issues on Windows. I will need to debug further I think.

Initialization for self-contained components is not supported
FAILURE: Type: 1, Error code: 80008093
Abort trap: 6

@AaronRobinsonMSFT
Copy link
Owner

Found it. There was another bug I had introduced when indicating how much of the buffer I had used.

*written = (int32_t)len;

The above should really be the buffer consumed not its length. This bug isn't in the Windows version.

@ghost
Copy link
Author

ghost commented May 24, 2020

@alberts2 As a confirmation was this observed on a non-Windows platform? I am occasionally still getting the following on macOS, but have no issues on Windows. I will need to debug further I think.
Initialization for self-contained components is not supported
FAILURE: Type: 1, Error code: 80008093
Abort trap: 6

On windows it only worked if it was run from somewhere on C: and it didn't work if it was placed on another volume like G:

@AaronRobinsonMSFT
Copy link
Owner

@alberts2 Okay. I will verify that scenario as well. There were at least 2 issues here and I have addressed both. The updated package has been published - https://www.nuget.org/packages/DNNE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant