Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid macro generated when project name contains '-' #46

Closed
Executor-Cheng opened this issue Nov 14, 2020 · 1 comment · Fixed by #47
Closed

Invalid macro generated when project name contains '-' #46

Executor-Cheng opened this issue Nov 14, 2020 · 1 comment · Fixed by #47
Labels
bug Something isn't working

Comments

@Executor-Cheng
Copy link
Contributor

var generatedHeaderDefine = $"__DNNE_GENERATED_HEADER_{assemblyName.Replace('.', '_').ToUpperInvariant()}__";

Maybe there should be assemblyName.Replace('.', '_').Replace('-', '_').ToUpperInvariant()?

@AaronRobinsonMSFT AaronRobinsonMSFT added the bug Something isn't working label Nov 15, 2020
@AaronRobinsonMSFT
Copy link
Owner

@Executor-Cheng Thanks for reporting this issue. I will get to this as soon as I can. Your proposed fix seems reasonable to me so feel free to submit a PR if you want. I guess it might make sense to think about other characters that might play havoc with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants