Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the native library to be explicitly named #59

Closed
sanny-io opened this issue Feb 6, 2021 · 2 comments · Fixed by #60
Closed

Allow the native library to be explicitly named #59

sanny-io opened this issue Feb 6, 2021 · 2 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@sanny-io
Copy link

sanny-io commented Feb 6, 2021

Not sure if this is possible, but messing with post-build events and such to rename it isn't ideal. An option to explicitly set the name instead of a suffix would be much easier for automation.

@AaronRobinsonMSFT
Copy link
Owner

@sanny-io Is the idea that more than a suffix is needed ? I assume this has more to do with the desire to name the native export binary as you want it rather than any real technical issue. Can you provide an example of how the native export binary is named vs the managed assembly?

@AaronRobinsonMSFT AaronRobinsonMSFT added the enhancement New feature or request label Feb 6, 2021
@sanny-io
Copy link
Author

sanny-io commented Feb 6, 2021

Correct. The native export binary appends NE to the managed assembly's name through the DnneNativeBinarySuffix property. What I propose is instead a property to outright set the generated binary's name. Perhaps a new DnneNativeBinaryName property that defaults to <DnneNativeBinaryName>$(TargetName)NE$(TargetExt)</DnneNativeBinaryName >

Managed name: managed.dll
Native binary: managedNE.dll <-- Allow to set the entire name, not just a suffix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants