Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API structures don't take config pointers #115

Open
obelisk opened this issue Dec 17, 2019 · 0 comments
Open

API structures don't take config pointers #115

obelisk opened this issue Dec 17, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@obelisk
Copy link
Collaborator

obelisk commented Dec 17, 2019

This means they can't be informed on changes to the config later which right now means changes in debug mode. There is no reason that we need to create the API structure before loading and parsing a config so if we just use a pointer we should be able to solve this problem.

Or we can change the calling convention and have config passed in as well like we do with commands.

@obelisk obelisk added the enhancement New feature or request label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant