Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosts.AddQueryToHost should be called by goquery #118

Open
zwass opened this issue Jan 14, 2020 · 1 comment
Open

hosts.AddQueryToHost should be called by goquery #118

zwass opened this issue Jan 14, 2020 · 1 comment
Labels
refactor For code changes that move code to better places or remove entirely

Comments

@zwass
Copy link
Contributor

zwass commented Jan 14, 2020

There seems to be an undocumented expectation that the API implementation calls this method. Can it just be called from within goquery?
@zwass
Copy link
Contributor Author

zwass commented Jan 14, 2020

Doing this would also allow hiding from history the query that goquery runs after connecting to a host.

@AbGuthrie AbGuthrie added the refactor For code changes that move code to better places or remove entirely label Jan 16, 2020
@AbGuthrie AbGuthrie mentioned this issue Jan 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor For code changes that move code to better places or remove entirely
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zwass @AbGuthrie