Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSO Properly #57

Open
obelisk opened this issue Oct 18, 2019 · 0 comments
Open

Implement SSO Properly #57

obelisk opened this issue Oct 18, 2019 · 0 comments
Assignees
Labels
mock server refactor For code changes that move code to better places or remove entirely wishlist

Comments

@obelisk
Copy link
Collaborator

obelisk commented Oct 18, 2019

The correct implementation for service protected by SSO or SAML auth is with a reverse proxy. The fact that goserver implements SAML on its own is at best inelegant.

This should be refactored into an nginx reverse proxy that handles saml and will pass along calls when authentication is successful. This would also mean another docker container for this service.

@obelisk obelisk added mock server refactor For code changes that move code to better places or remove entirely wishlist labels Oct 18, 2019
@obelisk obelisk self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mock server refactor For code changes that move code to better places or remove entirely wishlist
Projects
None yet
Development

No branches or pull requests

1 participant