Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please review the class DownloadIndicator. #4

Closed
Romavic opened this issue Jul 30, 2020 · 3 comments
Closed

Please review the class DownloadIndicator. #4

Romavic opened this issue Jul 30, 2020 · 3 comments

Comments

@Romavic
Copy link

Romavic commented Jul 30, 2020

In the DownloadIndicator class, if Text ('Downloading ...') appears, you should have the programmer's option to write whatever he wants in place of "Downloading".

So Text ('Downloading ...'), it should just be a Widget, which for anyone who wants to use the library should, put whatever he wants, while downloading the pdf ...

It may be the case that in place of Text ('Downloading ...'), I want to put a Gif ... or something else ...

Do you understand what I want?

@binSaed
Copy link
Owner

binSaed commented Jul 30, 2020

Hi @Romavic

thanks, for comments that helped me
less than 1 hour I will push new code

Screen Recording 2020-07-30 at 3 21 32 PM

@binSaed
Copy link
Owner

binSaed commented Jul 30, 2020

take a look now
https://github.com/AbdOoSaed/flutter_cached_pdfview#with-placeholder-until-pdffile-download-and-errorwidget-if-there-are-problem

@binSaed binSaed closed this as completed Aug 3, 2020
@Romavic
Copy link
Author

Romavic commented Aug 4, 2020

@AbdOoSaed It's better now ... Thanks for taking my suggestion into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants