-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more install info to error messages #46
Comments
So, the people over at |
I like that! We need similar messages in our part of the code. As mentioned in https://phabricator.wikimedia.org/T138121#2407656, IMHO there is a need for a final solution but I do not think this should be part of the current project. So I would say 'externals' has to come back in some way combined with the other approaches out there, but that something for the future... ;) https://gist.github.com/drtrigon/7231d760b26d8ea1370b35929da05f58 |
I've made a modification to the codebase now, which would give error messages like this if installation fails:
|
That look very nice!! I like it! Next step ask the user whether it should be done for convenience and then ask for permission to execute the command. That could be done using e.g. invoke. Dr. Trigon |
Running the test bot script gave me a very nice error message, see below - well done!
However I would like to mention to add also info for fedora distributions (yum) and may be others (osx, later win) so we should have this in manner easily adoptable - e.g. a dict at the beginning of a file or even a own file (like i18n e.g.).
The text was updated successfully, but these errors were encountered: