Feature to add a comment #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHP15
requested changes
Nov 23, 2022
There was a problem hiding this comment.
Hi @yonas44 great work 👍 , It was so close
STATUS: CHANGES REQUIRED ♻️
Here are some things you need to work on:
- Take a look at the comment below
- Kindly make sure that the comment show up un the screen when it gets added, because that is included in the project requirement
OPTIONAL:
Those are optional and you can skip them:
- Kindly give the form elements some padding, so it look nice on the screen
If you have any questions please feel free to ask 👍
Happy coding 💯
src/api/addComment.js
Outdated
| @@ -0,0 +1,27 @@ | |||
| const addComment = async (id, name, insight) => { | |||
| try { | |||
| const res = await fetch(`${process.env.INVOLVMENT_URL}/apps/${process.env.APP_ID}`, { | |||
There was a problem hiding this comment.
Please make sure that the URL is correct because the addComment is failing with status code 404
|
Thank you @Abdessittir for your feedback, I have added the changes please have a look at it and give me your feedback! |
AHP15
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Hi @yonas44 amazing work 💯, there is nothing to say other than it's time to merge your pull request.
STATUS: APPROVED 🥇
Highlights 💪🏻
✅ Comment posted to the API correctly
✅ No linter errors
✅ Dom manipulated to add new comment 💯
Happy Coding 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Abdessittir, so in this feature I implemented comment adding functionality, when you add a comment;