New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On smaller devices -- keyboard obscures suggestions and doesn't scroll #16
Comments
Hello @sjmcdowall , I apologize for taking so long to reply. I have been extremely overwhelmed in the past period, and now I am planning to get things back on track. Regarding the issue, this is most definitely the first item on the list. I will try to find a solution for it within the week. Thank you for reporting! |
I seemed to have figured out what the problem is. The list doesn't scroll because the list is showing all the elements (going off the screen), so it doesn't need to scroll. If we limit the size of the list for the _overlayEntry, ie:
we can force a height on the list. It will scroll now, but I haven't figured out a good way to determine the height yet. If the keyboard covers the bottom of the list, then we won't be able to see the last few elements. |
It’s even more complicated because many devices allow you to close the keyboard .. thus the height needs to be dynamic based on orientation and if keyboard is open/closed..
…Sent from my iPad
On Jan 1, 2019, at 3:46 PM, Kenneth Liang ***@***.***> wrote:
I seemed to have figured out what the problem is. The list doesn't scroll because the list is showing all the elements (going off the screen), so it doesn't need to scroll. If we limit the size of the list for the _overlayEntry, ie:
this._suggestionsBoxController._overlayEntry =
OverlayEntry(builder: (context) {
return Positioned(
width: size.width,
height: 300.0, // add this line
child: CompositedTransformFollower(
we can force a height on the list. It will scroll now, but I haven't figured out a good way to determine the height yet. If the keyboard covers the bottom of the list, then we won't be able to see the last few elements.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@KaYBlitZ I have enabled constraining the height:
But as @sjmcdowall indicated this does not solve the problem for all scenarios, and it is a bit tricky to get right. I apologize that it is taking longer than promised. |
Hi Abdul. I submitted a pull request that I think will fix this issue. Please check it out when you have time since I know you are very busy. |
@KaYBlitZ Thank you very much! I really appreciate it! I will check it out today around lunch time and will get back to you Have a great day! |
I just updated to this release (0.5.0) and am getting an error when the keyboard is shown on Android and it covers the suggestions box. Is there something else we need to configure with this release?
|
No. It should just work. Is the keyboard covering just the suggestions box or the text box as well? Looks like the keyboard is covering the text box based on the crash log calculating a negative height. I will take a look later if you can give more details on your setup. Might just need a check for negative height. |
Yes you are correct. When the keyboard launches it is covering the text box. |
I was able to replicate the problem by putting a text box at the very bottom of the screen. I created a pull request for the quick fix. |
This is a great widget. Our issue is that on smaller devices (specifically for us a user has an iPhone SE) and the initial suggestions comes up -- but when they tap in the box and the keyboard pops up -- the bottom of the list is obscured by the keyboard and scrolling doesn't "work". Meaning, it doesn't actually scroll it scrolls then pops back ... probably because it's confused that the text isn't visible by the keyboard?
Any workaround to this?
Also -- the "Done" button on iOS removes the keyboard, but also the scroll list and everything else -- so that didn't help :(
This is rather important for our users.. hoping for some ideas @AbdulRahmanAlHamali
The text was updated successfully, but these errors were encountered: