Improved support for VoiceOver/TalkBack #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rex26
reviewed
Jun 28, 2023
| // the style visually. However, when VO/TB are not enabled it is | ||
| // necessary to use the Positioned widget to allow the elements to be | ||
| // properly tappable. | ||
| return MediaQuery.of(context).accessibleNavigation |
There was a problem hiding this comment.
This will cause appium to be unable to select item
There was a problem hiding this comment.
Why? What exactly is the issue? To a human this appears to look decent and okay ...
There was a problem hiding this comment.
I need more time to pinpoint the root cause, but for now it looks like Align is causing the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before:
Untitled.1.mp4
After:
RPReplay_Final1659357543.MP4