Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scrollable issue #443

Closed
wants to merge 1 commit into from
Closed

Conversation

M1chlCZ
Copy link

@M1chlCZ M1chlCZ commented Dec 21, 2022

Fix for beta version of Flutter (currently 3.7)

Issue was that Scrollable.of(context) throws an error, if you try to invoke it without having scrollable context in ancestors. Method maybeOf will fix this issue.

@emersion
Copy link

emersion commented Jan 24, 2023

Flutter 3.7 is now released. @AbdulRahmanAlHamali, any chance to get this merged and released? :)

@emersion
Copy link

Hm, actually, even with this PR, the plugin doesn't work properly with Flutter 3.7: the suggestion InkWells cannot be tapped. Their onTap callback is never invoked.

@sjmcdowall
Copy link
Collaborator

I just released a new version for some PRs that may fix these issues in 3.7.0 .. give it a try

@ahmednfwela
Copy link

@sjmcdowall please revert latest version as it is causing errors:

AppData/Local/Pub/Cache/hosted/pub.dartlang.org/flutter_typeahead-4.3.1/lib/src/cupertino_flutter_typeahead.dart:649:40: Error: Member not found: 'Scrollable.maybeOf'.
    final scrollableState = Scrollable.maybeOf(context);

@emersion
Copy link

Unfortunately the new version doesn't fix the bug I described above: the list items can't be clicked.

@sjmcdowall
Copy link
Collaborator

@ahmednfwela -- are ytou on Flutter 3.7.0? The fix is for that

@sjmcdowall
Copy link
Collaborator

I'm closing THIS PR since it doesn't fix the one issue and the logic for 3.7 is in the code now via another PR ..

@sjmcdowall sjmcdowall closed this Jan 28, 2023
@ahmednfwela
Copy link

then please raise sdk constraints to 2.19.0 instead of 2.12.0

@sjmcdowall
Copy link
Collaborator

Good idea @ahmednfwela -- done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants