Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors causes inc/dec button decoration to displace. #29

Closed
Abhilash-Chandran opened this issue Sep 3, 2020 · 0 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Abhilash-Chandran
Copy link
Owner

Whenever a validation error is shown, the inc/dec buttons borders are displaced.

image

This is partially due to the way the Ink widget works and cannot be fixed in its current form. An Ink widget is required to give the ripple effect. But the border issue is cause t due to Ink widget not applying the decoration to its child. Check this.

flutter/flutter#21074

So it can be replaced with the solution proposed in the following issue until the above issue is fixed.
flutter/flutter#3782

Basically replace Ink with a Material widget and type as transparency and wrap it in a container to enforce the decoration.

@Abhilash-Chandran Abhilash-Chandran added the bug Something isn't working label Sep 3, 2020
@Abhilash-Chandran Abhilash-Chandran self-assigned this Sep 3, 2020
@Abhilash-Chandran Abhilash-Chandran added this to the Release 0.6.8 milestone Sep 3, 2020
@Abhilash-Chandran Abhilash-Chandran linked a pull request Sep 3, 2020 that will close this issue
@Abhilash-Chandran Abhilash-Chandran mentioned this issue Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant