Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving into PWA #7

Closed
Abhiramborige opened this issue Oct 2, 2021 · 6 comments · Fixed by #22
Closed

Improving into PWA #7

Abhiramborige opened this issue Oct 2, 2021 · 6 comments · Fixed by #22
Assignees
Labels
bug Something isn't working enhancement New feature or request hacktoberfest 2021 Opensource event hacktoberfest-accepted 2021 Opensource

Comments

@Abhiramborige
Copy link
Owner

Let app can be installed and work offline !
Performance was degraded when app was made into basic PWA. Please help

@Abhiramborige Abhiramborige added bug Something isn't working enhancement New feature or request hacktoberfest-accepted 2021 Opensource hacktoberfest 2021 Opensource event labels Oct 2, 2021
@meerhamzadev
Copy link
Contributor

meerhamzadev commented Oct 3, 2021

If I'm getting it right, You want when the user uses it without internet It shows an error message, Like connect to the internet or internet is not connected, etc?

@Abhiramborige
Copy link
Owner Author

If I'm getting it right, You want when the user uses it without internet It shows an error message, Like connect to the internet or internet is not connected, etc?

Not like that, but yes, I need this feature of getting "you are offline" message when user clicks on login, signup and connect form.
My issue is that before adding the service-worker.js, my app performance was 79% (lighthouse). But after adding the service-worker.js (same modifications as done in this video by fireshipio, https://youtu.be/sFsRylCQblw), the performance is down to 38% like that.
What happened I am not getting.

Would you like to provide the feature of "You are offline" page for the mentioned routes as above, then you are welcome. If wanted to resolve performance increment issue , then you are most welcome.

@meerhamzadev
Copy link
Contributor

Hey, Can I give the offline feature a try?

@meerhamzadev
Copy link
Contributor

Hey 👋, Just a question I'm facing a bit of difficulty while implementing offline feature with workbox. Can I replace the workbox service worker with a custom service worker? I think It also resolves the performance issue too.

@Abhiramborige
Copy link
Owner Author

ok, use anything until it is safer for the application

@Abhiramborige
Copy link
Owner Author

I dont have any deep idea on the workbox service provider

@Abhiramborige Abhiramborige linked a pull request Oct 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request hacktoberfest 2021 Opensource event hacktoberfest-accepted 2021 Opensource
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants