Added update_or_create method #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method allows us to use multiple keys to identify records, it replaces the implementation of `.refresh`. Fixes abletech#2
nigelramsay
reviewed
Jul 25, 2017
README.md
Outdated
| Easy::ReferenceData.refresh User, :system_code, 'nigel', name: 'Nigel Ramsay', email: 'nigel.ramsay@mailinator.com' | ||
| Easy::ReferenceData.refresh User, :system_code, 'fred', name: 'Fred Schmitt', email: 'fred.schmitt@mailinator.com' | ||
| Easy::ReferenceData.refresh User, :system_code, 'bert', name: 'Bert Symthe', email: 'bert.smythe@mailinator.com' | ||
| Easy::ReferenceData.update_or_create User, system_code: 'nigel', name: 'Nigel Ramsay', email: 'nigel.ramsay@mailinator.com', keys: [:system_code] |
There was a problem hiding this comment.
Should these examples be adjusted to separate the keys option from the User attributes? Eg:
Easy::ReferenceData.update_or_create User, {system_code: 'nigel', name: 'Nigel Ramsay', email: 'nigel.ramsay@mailinator.com'}, keys: [:system_code]
At the moment, it looks as if keys is just another attribute of User.
nigelramsay
reviewed
Jul 25, 2017
lib/easy/reference_data/refresh.rb
Outdated
| puts "..creating #{clazz}(#{unique_attribute_value})" | ||
| elsif record.changed? | ||
| puts "..updating #{clazz}(#{unique_attribute_value})" | ||
| puts "..creating #{clazz}(#{attributes.slice(*unique_attribute_keys)})" |
There was a problem hiding this comment.
at the moment, these puts statements are all writing to $stdout be default. I believe Unix convention is for these sort of debug/progress messages to write to $stderr. I suggest we change this at the same time.
nigelramsay
reviewed
Jul 25, 2017
lib/easy/reference_data/version.rb
Outdated
| @@ -1,5 +1,5 @@ | |||
| module Easy | |||
| module ReferenceData | |||
| VERSION = "0.1.2" | |||
| VERSION = "0.2.0" | |||
There was a problem hiding this comment.
maybe we should just go straight to version 1.0.0?
nigelramsay
reviewed
Jul 25, 2017
nigelramsay
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method allows us to use multiple keys to identify records, it replaces the implementation of
.refresh.Fixes #2