Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show property values and missing ones on dataset's main page #1705

Closed
benedeki opened this issue Feb 28, 2021 · 4 comments · Fixed by #1851
Closed

Show property values and missing ones on dataset's main page #1705

benedeki opened this issue Feb 28, 2021 · 4 comments · Fixed by #1851
Assignees
@AdrianOlosutean
Labels
feature New feature Menas Menas component affected priority: high Critical to the health of the project under discussion Requires consideration before a decision is made whether/how to implement UX Something concerning UX

Comments

@benedeki
Copy link
Collaborator

Background

Staring version v2.18.0 is possible to set dataset properties. And v2.20.0 UI supports the UI supports proprties as well.
But the properties are only shown when editing the dataset, not on the overview page.

Feature

Show the properties defined for the dataset on the main page, not only when the dataset is edited.
Also shown defined but missing properties.

Example

Somewhere here. Or as a new button.
image
@benedeki benedeki added feature New feature Menas Menas component affected under discussion Requires consideration before a decision is made whether/how to implement UX Something concerning UX priority: undecided Undecided priority to be assigned after discussion labels Feb 28, 2021
@benedeki benedeki added priority: high Critical to the health of the project under discussion Requires consideration before a decision is made whether/how to implement and removed priority: undecided Undecided priority to be assigned after discussion under discussion Requires consideration before a decision is made whether/how to implement labels Jul 7, 2021
@benedeki
Copy link
Collaborator Author

Unfortunately, it's not just the UI filtering out the non-assigned properties.
The dataset API is not returning them.
I see two options:

  1. Enhance the API
  2. Combine the properties returned by the API with the properties definition which do exist with the Menas UI app

@AdrianOlosutean
Copy link
Contributor

At a first glance, it seems like the second option is the more accessible one, but it may be necessary to do an extra request

@benedeki
Copy link
Collaborator Author

Yeah, maybe better for faster delivery. And I think the properties defs might be already loaded into the model... 🤔

@AdrianOlosutean AdrianOlosutean mentioned this issue Jul 15, 2021
Merged
@AdrianOlosutean
Copy link
Contributor

Release notes
Missing properties are shown in the Dataset info page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianOlosutean AdrianOlosutean

Labels
feature New feature Menas Menas component affected priority: high Critical to the health of the project under discussion Requires consideration before a decision is made whether/how to implement UX Something concerning UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1705 show properties missing on dataset main page AbsaOSS/enceladus
2 participants
@AdrianOlosutean @benedeki