Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperConformance report version from payload #1881

Closed
kevinwallimann opened this issue Aug 13, 2021 · 1 comment · Fixed by #1896
Closed

HyperConformance report version from payload #1881

kevinwallimann opened this issue Aug 13, 2021 · 1 comment · Fixed by #1896
Assignees
Labels
feature New feature priority: undecided Undecided priority to be assigned after discussion under discussion Requires consideration before a decision is made whether/how to implement

Comments

@kevinwallimann
Copy link
Contributor

Background

Currently, in the HyperConformance plugin, the enceladus_info_version can only be set through report.version with a static value. It is a desired feature from source teams to set enceladus_info_version dynamically based on a field from the payload, similarly how event.timestamp.column can be used to set the value for enceladus_info_date.

Feature

Add an attribute (e.g. report.version.column) that accepts the name of an Int-column. That Int-column should be used as the value for enceladus_info_version.

Example

Given a dataframe

key value custom_version
100 abc 1
101 xyz 1
100 ABC 2
101 XYZ 2

With HyperConformance configuration

  • dataset.name=Some_Dataset
  • dataset.version=1
  • ...
  • report.version.column=custom_version

The conformed dataframe should look like this

key value custom_version enceladus_info_date enceladus_info_date_string enceladus_info_version
100 abc 1 ... ... 1
101 xyz 1 ... ... 1
100 ABC 2 ... ... 2
101 XYZ 2 ... ... 2

(Dates are omitted)

@kevinwallimann kevinwallimann added feature New feature under discussion Requires consideration before a decision is made whether/how to implement priority: undecided Undecided priority to be assigned after discussion labels Aug 13, 2021
@kevinwallimann kevinwallimann changed the title HyperConformance report date from payload HyperConformance report version from payload Aug 23, 2021
@AdrianOlosutean
Copy link
Contributor

AdrianOlosutean commented Sep 10, 2021

Release notes
New way of having HyperConformance info_version_column from an existing dataframe column by specifying report.version.column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature priority: undecided Undecided priority to be assigned after discussion under discussion Requires consideration before a decision is made whether/how to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants