Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Import Dataset validate extra output columns of MappingTableConformanceRule #1904

Closed
Zejnilovic opened this issue Sep 6, 2021 · 1 comment · Fixed by #1948
Closed

On Import Dataset validate extra output columns of MappingTableConformanceRule #1904

Zejnilovic opened this issue Sep 6, 2021 · 1 comment · Fixed by #1948
Assignees
@AdrianOlosutean
Labels
feature New feature good first issue Good for newcomers priority: undecided Undecided priority to be assigned after discussion Rest-API Rest-API component affected

Comments

@Zejnilovic
Copy link
Contributor

Background

We added additionalColumns to MappingConformanceRule but did not add validation of these fields on import

Feature

On Import Dataset validate extra output columns of MappingTableConformanceRule
@Zejnilovic Zejnilovic added feature New feature under discussion Requires consideration before a decision is made whether/how to implement priority: undecided Undecided priority to be assigned after discussion labels Sep 6, 2021
@benedeki benedeki added Rest-API Rest-API component affected good first issue Good for newcomers and removed under discussion Requires consideration before a decision is made whether/how to implement labels Sep 15, 2021
@AdrianOlosutean AdrianOlosutean mentioned this issue Oct 15, 2021
Merged
@AdrianOlosutean AdrianOlosutean self-assigned this Oct 25, 2021
@AdrianOlosutean
Copy link
Contributor

Release notes
On Import Dataset, all output columns of MappingTableConformanceRule will be validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianOlosutean AdrianOlosutean

Labels
feature New feature good first issue Good for newcomers priority: undecided Undecided priority to be assigned after discussion Rest-API Rest-API component affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1904 validate mapping table additional fields AbsaOSS/enceladus
3 participants
@AdrianOlosutean @benedeki @Zejnilovic